Rails4 enum column support #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We can't use `send` because send won't gives us DB values on enum
|
Thanks @arunagw ! I think the build failures are because of Rails 3 support. Maybe we should remove it. |
|
@swanandp you mean support for Rails3? May be a check with Rails version? |
|
I meant we should just remove the Rails3 Gemfile. Because we are not supporting Rails3 in this version. There are older versions for that. |
|
I was kinda thinking aloud. :-) |
|
@arunagw can you set up the test to check for Rails version? Run it only if >= 4 ? |
|
@swanandp I will have a look again soon. |
Restrict enum-specific tests to the rails4 env
| @@ -33,6 +37,10 @@ def rails_3 | |||
| defined?(ActiveRecord::VERSION) && ActiveRecord::VERSION::MAJOR >= 3 | |||
| end | |||
|
|
|||
| def rails_4 | |||
There was a problem hiding this comment.
How about renaming it to rails_4?
|
I dropped Ruby 1.9.2 support, so we are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendbecause send won't gives us DB values on enum