Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require rails when loading #146

Merged
merged 1 commit into from
Jan 14, 2015
Merged

Don't require rails when loading #146

merged 1 commit into from
Jan 14, 2015

Conversation

botandrose
Copy link
Contributor

Fixes #145.

@botandrose
Copy link
Contributor Author

Failure appears to be a red herring. Rubinius can't find 'psych'... pretty sure that's unrelated to this PR.

@amatsuda
Copy link
Contributor

As an author of #114, I can confirm that this change does no harm to typical users that use bundler to run their rails apps.
Because config/application.rb executes require 'rails'here before bundling the gems, Rails::Railtie should always be already defined when requiring acts_as_list.rb
So this PR is OK to merge.

@amatsuda amatsuda mentioned this pull request Jan 14, 2015
Closed
swanandp added a commit that referenced this pull request Jan 14, 2015
@swanandp
Merge pull request #146 from botandrose/dont_load_rails
ab850ff 
Don't require rails when loading
@swanandp swanandp merged commit ab850ff into brendon:master Jan 14, 2015
@swanandp
Copy link
Contributor

Looks good to me as well, thanks @botandrose for contributing, and @amatsuda for reviewing!

@botandrose
Copy link
Contributor Author

Thanks, everyone!

@botandrose botandrose deleted the dont_load_rails branch January 14, 2015 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can no longer load acts_as_list in isolation if Rails is installed
4 participants
@botandrose @amatsuda @swanandp @botandrose-machine