Fix ambiguous column error when joining some relations #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,64 @@ | |||
| require 'helper' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
done |
|
Thanks for that. I think there are some inconsistencies now regarding the use of Can you use |
added 3 commits
May 2, 2016 09:40
Joining the relation returned by `#higher_items` or `#lower_items` to a table also having `position_column` would result in an ambiguous column error
|
there you go. Sorry for the slow response. |
|
Thanks for that :) I've merged that now for you. Expect a new gem in the next week or two once a few other issues get closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining the relation returned by
#higher_itemsor#lower_itemsto a table also havingposition_columnwould result in an ambiguous column error.The new test file might be a bit heavy handed, but
test_list.rbis somewhat...opaque. :)The test cases are pretty close to my actual use case, and I admit that it's a slightly awkward one.
I have a
visiblescope onItemthat joins onSection, but in the case of the query set returned bylower_items, it's already scoped to a particularSection.So I could just say
.where(visible: true)instead of.visible, which would avoid the unnecessary join, and I'll probably just do that in the meantime.Still, I think this is probably a change for the better.