New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote all identifiers #205

Merged

brendon merged 3 commits into brendon:master from fabn:quoting

Apr 18, 2016

Contributor

fabn commented Apr 18, 2016

This will fix #174. Also it support position columns with reserved names (e.g. order)

fabn added 3 commits

April 18, 2016 15:53


          Reproducing brendon#174 with a test case

d107593


          Always quote position column when using it in string conditions

48585b9


          Always quote table name when using it in string conditions

3764c0b

fabn mentioned this pull request

Escapes table name to fix Mysql2 errors #174

Closed

Owner

brendon commented Apr 18, 2016

Looks good :) @fabn, I'll merge this now.

brendon merged commit 2017998 into brendon:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet