Use before validate instead of before create #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidate presence of postion if needed
swanandp
added a commit
that referenced
this pull request
Nov 24, 2011
…efore_create Use before validate instead of before create
|
Pulled! Thanks for contributing! |
|
For those landing here, in the latest version the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to having not null for column in database we could have rails validation for presence of column. However if position is assigned after validation, then validation would not pass and record would not be saved.
Changed both code and spec, however additional changes may be required for older versions of rails, I am not sure about callback syntax for old rails versions, probably will need any conditional there.