Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
swanandp left a comment
A word on commits: I am normally not a fan of squashing commits, and I like how you've made small atomic commits which make your refactoring process clear.
However, for such a small diff, having 14 commits will make it future "blaming" a little tedious. In this case, I think it would be beneficial to have them merged together.
If you agree, please squash them together and rebase against master if needed. But if you strongly feel inclined to keep the commits as they are, let me know.