Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fixnum deprecation warnings. #282

Merged

Conversation

patrickdavey
Copy link
Contributor

Fixnum is being deprecated and merged with Bignum into Integer
(http://blog.bigbinary.com/2016/11/18/ruby-2-4-unifies-fixnum-and-bignum-into-integer.html)

This PR replaces Fixnum with Integer (in the tests) and fixes the
deprecation warnings

Fixnum is being deprecated and merged with Bignum into Integer
(http://blog.bigbinary.com/2016/11/18/ruby-2-4-unifies-fixnum-and-bignum-into-integer.html)

This PR replaces Fixnum with Integer (in the tests) and fixes the
deprecation warnings
@brendon brendon merged commit 2e6a614 into brendon:master Jun 18, 2017
@brendon
Copy link
Owner

brendon commented Jun 18, 2017

Excellent! :) Thanks @patrickdavey.

@krzysiek1507
Copy link
Contributor

What's the file file:memdb1?mode=memory&cache=shared? ;)

@brendon
Copy link
Owner

brendon commented Jul 2, 2017

I can't quite remember but you can use the blame feature of github to find out what the related commit was. I think it was to do with simulating race conditions.

@krzysiek1507
Copy link
Contributor

krzysiek1507 commented Jul 2, 2017

It has been added with this PR and it looks like SQLite file.

@brendon
Copy link
Owner

brendon commented Jul 2, 2017

Not according to the files list: https://github.com/swanandp/acts_as_list/pull/282/files

@krzysiek1507
Copy link
Contributor

I can see it.

screenshot-github com 2017-07-02 23-02-56

@brendon
Copy link
Owner

brendon commented Jul 2, 2017

Ah I see! Sorry it doesn't really stand out at all in the list does it. I've committed a removal directly to master.

@krzysiek1507
Copy link
Contributor

No problem! Thanks!

@patrickdavey
Copy link
Contributor Author

My apologies for that :( I should have been more careful, usually am but it slipped through! Thanks @krzysiek1507 for pointing that out, and @brendon for fixing it.

@brendon
Copy link
Owner

brendon commented Jul 4, 2017

Hey no worries :D We haven't released a gem yet anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants