-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fixnum deprecation warnings. #282
Fix Fixnum deprecation warnings. #282
Conversation
Fixnum is being deprecated and merged with Bignum into Integer (http://blog.bigbinary.com/2016/11/18/ruby-2-4-unifies-fixnum-and-bignum-into-integer.html) This PR replaces Fixnum with Integer (in the tests) and fixes the deprecation warnings
Excellent! :) Thanks @patrickdavey. |
What's the file |
I can't quite remember but you can use the blame feature of github to find out what the related commit was. I think it was to do with simulating race conditions. |
It has been added with this PR and it looks like SQLite file. |
Not according to the files list: https://github.com/swanandp/acts_as_list/pull/282/files |
Ah I see! Sorry it doesn't really stand out at all in the list does it. I've committed a removal directly to master. |
No problem! Thanks! |
My apologies for that :( I should have been more careful, usually am but it slipped through! Thanks @krzysiek1507 for pointing that out, and @brendon for fixing it. |
Hey no worries :D We haven't released a gem yet anyway :) |
Fixnum is being deprecated and merged with Bignum into Integer
(http://blog.bigbinary.com/2016/11/18/ruby-2-4-unifies-fixnum-and-bignum-into-integer.html)
This PR replaces Fixnum with Integer (in the tests) and fixes the
deprecation warnings