Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions to README.md #35

Merged
merged 1 commit into from May 1, 2012

Conversation

mark-rushakoff
Copy link
Contributor

Because there weren't any installation instructions in the README, and because the project is still marked as a fork from rails, I incorrectly assumed that I had to specify the git repository in my Gemfile to get your version of the gem. This commit adds to the README to clarify that it is indeed as easy as gem install acts_as_list. Hopefully this saves a few minutes for someone else.

swanandp added a commit that referenced this pull request May 1, 2012
Add installation instructions to README.md
@swanandp swanandp merged commit 729308e into brendon:master May 1, 2012
@swanandp
Copy link
Collaborator

swanandp commented May 1, 2012

Pulled, thanks! Though the last bit "Then, in your source file.." is not
required. I'll remove it if you don't mind.

On Tue, May 1, 2012 at 1:29 AM, Mark Rushakoff <
reply@reply.github.com

wrote:

Because there weren't any installation instructions in the README, and
because the project is still marked as a fork from rails, I incorrectly
assumed that I had to specify the git repository in my Gemfile to get your
version of the gem. This commit adds to the README to clarify that it is
indeed as easy as gem install acts_as_list. Hopefully this saves a few
minutes for someone else.

You can merge this Pull Request by running:

git pull https://github.com/mark-rushakoff/acts_as_listinstallation-instructions

Or you can view, comment on it, or merge it online at:

#35

-- Commit Summary --

  • Add installation instructions to README.md

-- File Changes --

M README.md (13)

-- Patch Links --

https://github.com/swanandp/acts_as_list/pull/35.patch
https://github.com/swanandp/acts_as_list/pull/35.diff


Reply to this email directly or view it on GitHub:
#35

@mark-rushakoff
Copy link
Contributor Author

Of course I don't mind if you remove it. I did notice that my project didn't have a require 'acts_as_list' line, but I assumed it was coming in via Bundler.require or some such.

Thanks for accepting the pull request!

@swanandp
Copy link
Collaborator

swanandp commented May 1, 2012

Right, bundler does a require by default, unless you specify :require => false in your gem declaration in the Gemfile.

On Tue, May 1, 2012 at 11:13 AM, Mark Rushakoff <
reply@reply.github.com

wrote:

Of course I don't mind if you remove it. I did notice that my project
didn't have a require 'acts_as_list' line, but I assumed it was coming
in via Bundler.require or some such.

Thanks for accepting the pull request!


Reply to this email directly or view it on GitHub:
#35 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants