Add Tests ruby 2.7 and 3.0 for integration test #393
Merged
+35
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QWYNG
changed the title
QWYNG
commented
Apr 19, 2021
| @@ -11,7 +11,7 @@ def setup_db(position_options = {}) | |||
|
|
|||
| # AR caches columns options like defaults etc. Clear them! | |||
| ActiveRecord::Base.connection.create_table :mixins do |t| | |||
| t.column :pos, :integer, position_options unless position_options[:positive] && sqlite | |||
| t.column :pos, :integer, **position_options unless position_options[:positive] && sqlite | |||
There was a problem hiding this comment.
Ruby 2.7.3 warning
❯ rake test
Run options: --seed 34339
# Running:
#{HOME}/acts_as_list/test/test_list.rb:14: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/#{HOME}/.rbenv/versions/2.7.3/lib/ruby/gems/2.7.0/gems/activerecord-6.1.3.1/lib/active_record/connection_adapters/abstract/schema_definitions.rb:401: warning: The called method `column' is defined here
..................................................................................................................................................................................................
Finished in 15.685896s, 12.3678 runs/s, 62.0940 assertions/s.
194 runs, 974 assertions, 0 failures, 0 errors, 0 skips
d8f618d to
c6fcbf5
Compare
QWYNG
force-pushed
the
add_test_for_ruby_2_7_and_3_0
branch
from
c6fcbf5 to
a83dde6
Compare
QWYNG
commented
Apr 19, 2021
| gemfile: gemfiles/rails_4_2.gemfile | ||
| # Ruby 2.7 warning `sqlite3-1.3.13/lib/sqlite3/statement.rb:108: warning: rb_tainted_str_new is deprecated` | ||
| # and job wil exceed the maximum log length | ||
| # see also: https://github.com/sparklemotion/sqlite3-ruby/issues/276 |
There was a problem hiding this comment.
There was a problem hiding this comment.
The warning also occurs with the ranked-model.
https://travis-ci.org/github/mixonic/ranked-model/jobs/755121129
|
Looks good to me @QWYNG, well done on getting this all green. Travis can be a temperamental beast at times :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #392
special thanks to @aried3r.
I thank him for the kind offer.
I referred to the following commit.
brendon/ranked-model#174
brendon/ranked-model#168