Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support accepts_nested_attributes_for multi-destroy #46

Merged
merged 1 commit into from Aug 17, 2012

Conversation

saberma
Copy link
Contributor

@saberma saberma commented Jul 29, 2012

Hi, there is a bug when we use accepts_nested_attributes_for multi-destroy.
And here is the patch to solve this problem with simple test.

@swanandp
Copy link
Collaborator

swanandp commented Aug 9, 2012

Apologies for the delay. I'v been busy. I will take a look at this in the next few days and let you know.

@ghost
Copy link

ghost commented Aug 16, 2012

+1

We were hit badly by this bug, and this patch fixes our test case.

swanandp added a commit that referenced this pull request Aug 17, 2012
support accepts_nested_attributes_for multi-destroy
@swanandp swanandp merged commit f62c432 into brendon:master Aug 17, 2012
@swanandp
Copy link
Collaborator

Pulled, thanks! Although, can you please use the gihub link in your Gemfile, I have a few other changes that I need to push before I can release a new gem.

@saberma
Copy link
Contributor Author

saberma commented Aug 18, 2012

I have use this repo github link in my Gemfile, and all the test were passed now.

Thanks.

@LaurentSHB
Copy link

Hi, for information, this pull-request seems to cause an issue with dependent: :destroy and acts_as_tree. It's very specific so I don't know if somebody else had the problem.

I explain it here with details: http://stackoverflow.com/questions/17695206/dependent-destroy-with-acts-as-tree-and-acts-as-list/17807496#17807496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants