-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted into a gem... plus some slight refactors #6
Conversation
Interesting. Let me go over this and then merge. Sounds okay? |
absolutely! |
I also added a gemspec, because then I can make it a target for Bundler, and use it in ActiveRecord despite not being on Rails. I've got my Gemfile pointing at my repo, but while I think it's the best solution right now, I'd like it a lot more if I could point at this one, whether you put it on Rubygems or not. Wasn't going to say anything, my solution fits my needs, but was just reading a blog and its commenters said this was the proper etiquette for forkers. |
There is already a gem present by the name |
I agree getting this under the same name on rubyforge would be clutch. Let me know if you need any leg work done on that end. |
Hey @swanandp I do have access to the gem on rubygems, but not rubyforge. I was given access when we took over maintaining this library. I'll see if I can get you access to rubygems. |
@swanandp You're an owner on rubygems now too. |
Well I am a gem lover... so I thought this would be a good opportunity to progress in my ability to create gems.
So this is just your project wrapped in a gem. The gem is in rubygems.org filed under the name 'acts_as_list-rails3'.
The refactoring note was two fold:
I understand this isn't a necessary pull, so I wont cry if you decide not to :)
Cheers!