Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted into a gem... plus some slight refactors #6

Merged
merged 8 commits into from
Jun 10, 2011

Conversation

chaffeqa
Copy link
Contributor

Well I am a gem lover... so I thought this would be a good opportunity to progress in my ability to create gems.

So this is just your project wrapped in a gem. The gem is in rubygems.org filed under the name 'acts_as_list-rails3'.

The refactoring note was two fold:

  1. Two of the tests were failing, both due to rails3 changes. I fixed both so they perform the updated rails3 methods if the ActiveRecord is version > 3
  2. Due to gemspec structuring, I made a few filesystem level changes to the /lib dir. The only impact those had code-wise was in init.rb. I simply moved some of the require statements to the file /lib/acts_as_list.rb.

I understand this isn't a necessary pull, so I wont cry if you decide not to :)

Cheers!

@swanandp
Copy link
Contributor

Interesting. Let me go over this and then merge. Sounds okay?

@chaffeqa
Copy link
Contributor Author

absolutely!

@JoshCheek
Copy link

I also added a gemspec, because then I can make it a target for Bundler, and use it in ActiveRecord despite not being on Rails. I've got my Gemfile pointing at my repo, but while I think it's the best solution right now, I'd like it a lot more if I could point at this one, whether you put it on Rubygems or not.

Wasn't going to say anything, my solution fits my needs, but was just reading a blog and its commenters said this was the proper etiquette for forkers.

@swanandp
Copy link
Contributor

swanandp commented Jun 6, 2011

There is already a gem present by the name acts_as_list on Rubyforge. I think @amerine has access to it. https://rubygems.org/gems/acts_as_list
I'll request him to add me there, and we can push this under the same. But thanks for the pull request!

@chaffeqa
Copy link
Contributor Author

chaffeqa commented Jun 7, 2011

I agree getting this under the same name on rubyforge would be clutch. Let me know if you need any leg work done on that end.

@amerine
Copy link

amerine commented Jun 7, 2011

Hey @swanandp I do have access to the gem on rubygems, but not rubyforge. I was given access when we took over maintaining this library. I'll see if I can get you access to rubygems.

@amerine
Copy link

amerine commented Jun 9, 2011

@swanandp You're an owner on rubygems now too.

@swanandp swanandp merged commit f7bdd42 into brendon:master Jun 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants