Make example code in the README compile #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background - I was modeling some code after the examples in the README and was puzzled to find that compiling it in release mode caused it to cease functioning. I think this was due to the
assert open()statements in the VCF being optimized away.I'm sure this is due to me being an extreme novice in Nim, but I thought perhaps adjusting the example code would help other novices. Right now this is just a commit to the first example to enable it to compile (not even sure if I've used the library properly).
The VCF example is a bit more involved and I thought I'd ask whether it'd be preferable to simply discard the return values of the open statements and info field retrieval or exhibit error checking before trying to push some updates to the VCF example.