Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright information - should this possibly be more specific? Pointer to original kexpr? #2

Closed
smoe opened this issue Nov 4, 2020 · 3 comments

Comments

@smoe
Copy link
Contributor

smoe commented Nov 4, 2020

Hello,

Everything builds and tests nicely. So you are providing a complete package, i.e. are including what you wrapped.
You are wrapping something that I had expected to find somewhere on
https://github.com/lh3
together with the original license - but I failed. So, is it all yours since you reimplemented it? But why then say you wrapped someone else's work? Please kindly help your README.md / LICENSE file to clear this up and/or add a short header in kexpr/*.[ch].

Many thanks
Steffen

@smoe
Copy link
Contributor Author

smoe commented Nov 5, 2020

Hm. It likely is https://github.com/lh3/bgt/blob/master/LICENSE.txt (MIT again, thanks go to Nilesh for spotting that) but a quick confirmation would be nice.

@brentp
Copy link
Owner

brentp commented Nov 5, 2020

Hi Steffen, it's from here: https://github.com/attractivechaos/klib
do you want to open a pull-request with your suggested changes?

@smoe
Copy link
Contributor Author

smoe commented Nov 6, 2020

do you want to open a pull-request with your suggested changes?

#3

@smoe smoe closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants