Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bwa-mem2 2.2.1 #1494

Closed
wants to merge 3 commits into from
Closed

bwa-mem2 2.2.1 #1494

wants to merge 3 commits into from

Conversation

gl-eb
Copy link
Contributor

@gl-eb gl-eb commented Feb 10, 2022

Created with brew bump-formula-pr.

@heuermh
Copy link
Contributor

heuermh commented Sep 12, 2023

@gl-eb Might you be able to rebase this pull request?

@gl-eb
Copy link
Contributor Author

gl-eb commented Sep 13, 2023

Done!

@heuermh
Copy link
Contributor

heuermh commented Sep 16, 2023

Sorry, will have to ask you to do it again, to pick up fixes to CI. 😬

Alternatively, I see some force pushed commits above, but I'm not certain how those were done?

$ git remote add gl-eb https://github.com/gl-eb/homebrew-bio.git
$ git fetch gl-eb
$ git checkout gl-eb/bump-bwa-mem2-2.2.1

# rebase, would require force push
$ git rebase -i upstream/develop

# or create merge commit, would also require a push to your branch?
$ git pull upstream/develop --no-rebase

@gl-eb
Copy link
Contributor Author

gl-eb commented Sep 18, 2023

No worries, my part is easy to do. Thanks for trying to get this to work!

@gl-eb
Copy link
Contributor Author

gl-eb commented Sep 19, 2023

I think the issue is an incompatibility between bwa-mem2 v2.2.1 with GCC 11 and higher. There's a fix for this already, but it has not been tagged as a release.

Does Homebrew allow formulas where tag and revision do not match? Otherwise the only other option would be to ask the bwa-mem2 maintainers to tag a new release. Or am I wrong here?

I am happy to do either, though the latter option could take longer. Do you have a preference @heuermh ?

@heuermh
Copy link
Contributor

heuermh commented Sep 19, 2023

Yes, the CI issues have been resolved and now we're left with the actual issue with bwa-mem2!

Cleanest option is to wait until a new release happens upstream, otherwise we could patch and/or create a homebrew-specific revision with that commit included. Perhaps also this patch? I am not sure what the appetite for such here is though.

@YoshitakaMo
Copy link
Contributor

@gl-eb I've created bwa-mem2 binaries for Apple Silicon (658fb60), though I don't guarantee whether it works as expected. If you are interested, please test it.

@YoshitakaMo YoshitakaMo closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants