pg.end() doesn't always end the connections

[fsateler]

Simple testcase:

var opts = {
    "driver": "postgres",
    "host": "localhost",
    "user": "nodetest",
    "password": "password",
    "database": "nodetest"
}


var pg = require('pg');

pg.connect(opts, function(err, client) {
    pg.end();
});

Then executing it:

% time node test_pg.js
^Cnode test_pg.js  2.49s user 0.66s system 0% cpu 14:10.42 total

I halted the program after 14 minutes. If I modify it like this:

var opts = {
    "driver": "postgres",
    "host": "localhost",
    "user": "nodetest",
    "password": "password",
    "database": "nodetest"
}


var pg = require('pg');

pg.connect(opts, function(err, client) {
    client.query('select * from person', function(){
        pg.end();
    });
});

Then it works:

% time node test_pg.js
node test_pg.js  0.12s user 0.02s system 11% cpu 1.142 total

[freewil]

you should be calling client.end()

[brianc]

yah, gotta explicitly client.end() if the client was issued 0 queries. This actually probably is a bug...I'll try to take a look at it...oooooor if you wanna pull request 'em that'd be groovy. 🐙

[fsateler]

Ehm... According to the docs, calling pg.end will kill any connection (not cleanly). It specifically says it is intended for unit tests. I came across this bug because my unit tests were not ending even when I called pg.end().

[ardiesaeidi]

@brianc i got caught out by this too. Docs say it can kill the connection but looks like if the client hasn't issued any queries then the connection stays open. Only way i was able to release the connection was to emit the drain event or issue empty query.

Simple fix might be to also emit drain event when you call end()? Since your pooling logic is relying on it:

https://github.com/brianc/node-postgres/blob/master/lib/index.js#l71-73

[brianc]

pg.end should work correctly now

I've changed the pool substantially to no longer rely on the drain event at all. No pauseDrain no resumeDrain. Documentation is a work in progress.

https://github.com/brianc/node-postgres/wiki/pg
#274