Skip to content

Misleading comment in defaults about max pool size #1977

@wraithgar

Description

@wraithgar

There is a comment in the defaults file stating that setting max to 0 disables pooling. I do not think this is true, as the underlying pg-pool lib sees that as a falsey value and defaults to 10

Here is the comment

// 0 will disable connection pooling

Here is the relevant line in pg-pool
https://github.com/brianc/node-pg-pool/blob/2d2a87392ceaf73ba0d2ed13ed9f6857e1d72ddd/index.js#L63

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions