Unhandled 'error' event thrown when the connection password doesn't match

[david-rouchet]

When I connect to an existing database with the connect username but the wrong password, I got an unhandled exception using the following code. The parameter err is set, but the exception is still thrown.

pg.connect(dbURL, function(err, client, done) {
  if(err) {
    return console.error('error fetching client from pool', err);
  }
  client.query('SELECT $1::int AS number', ['1'], function(err, result) {
    //call `done()` to release the client back to the pool
    done();

    if(err) {
      return console.error('error running query', err);
    }
    console.log(result.rows[0].number);
    //output: 1
    client.end();
  });
});

[brianc]

That's odd...I'm pretty sure we have a test for that in the unit tests.
What version of PG & node-postgres?

On Wed, Mar 11, 2015 at 4:48 PM, david-rouchet notifications@github.com
wrote:

When I connect to an existing database with the connect username but the
wrong password, I got an unhandled exception using the following code. The
parameter err is set, but the exception is still thrown.

pg.connect(dbURL, function(err, client, done) {
if(err) {
return console.error('error fetching client from pool', err);
}
client.query('SELECT $1::int AS number', ['1'], function(err, result) {
//call done() to release the client back to the pool
done();

if(err) {
  return console.error('error running query', err);
}
console.log(result.rows[0].number);
//output: 1
client.end();

});
});

—
Reply to this email directly or view it on GitHub
#746.

[david-rouchet]

pg version is 4.3.0, node-js is 0.10.31 and postgreSQL server is 9.3.5

[david-rouchet]

Hi there,
any clue, bug fiix or suggestion on this issue?

[tsoule]

Hi, I am encountering the same issue when using an incorrect username. My callback to pg.connect is executed with a "password authentication failed..." error, which I deal with. However, an ECONNRESET error is subsequently emitted, hitting this line, and there is no way for me to handle it. I tested with node-postgres (not native) 4.3.0 on Windows and Mac. I am running PostgreSQL 9.4 on Windows.

[david-rouchet]

I still have the same issue and this become a concern for the project I'm working on...

[vitaly-t]

+1
Happens here always when the password is incorrect.

[kamushkin]

+1

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: read ECONNRESET
    at errnoException (net.js:901:11)
    at TCP.onread (net.js:556:19)

happens when calling pg.connect with either user, password or db incorrect.
windows7, node v0.10.22, PostgreSQL 9.4.1, pg 4.3.0

[david-rouchet]

So far no fix has been proposed. Does anywone see a way to workaround this issue? We still have a project going on and which is fragilized by this error.

[brianc]

I think the best work around would be to submit a failing test or even better some code to fix the issue in a PR. 😉

I can't reproduce the issue locally - the error is correctly passed to the callback with both a bad host or bad username.

I also already have test cases covering this issue and they pass:

https://github.com/brianc/node-postgres/blob/master/test/integration/client/error-handling-tests.js#L136
https://github.com/brianc/node-postgres/blob/master/test/native/connection-tests.js#L5

[kamushkin]

Looks like the right test (user/password) is commented out (?) -
https://github.com/brianc/node-postgres/blob/master/test/integration/client/error-handling-tests.js#L148

The one you refer to is about invalid host (means no response instead of refusing connection) -
https://github.com/brianc/node-postgres/blob/master/test/integration/client/error-handling-tests.js#L136

Here is also the minimum code to reproduce the issue -

var pg = require('pg');

pg.connect('postgres://abc:def@localhost:5432/xyz', function (err, db, done) {
    console.log('connect callback called');
});

which produces

connect callback called

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: read ECONNRESET
    at errnoException (net.js:901:11)
    at TCP.onread (net.js:556:19)

I did not test this with native bindings - possibly the issue is limited to js

[david-rouchet]

I do agree, the unhandled error occurs when the server can be reached but either the username or the password is incorrect.

Another code example which reproduces this error.

In this example, 'postGres' should be 'postgres'. So if 'postGres' is used instead of 'postgres' the Unhandled exception is raised.

var pg = require('pg');
var dbURL = 'postgres://postgres:postGres@192.168.1.81/dbname';

if (0) { // whether this code is activated or not, the error is not catched
  pg.on( 'error', function(err) {
    console.log('do nothing');
  });
}

try {
  pg.connect( dbURL, function(err, client, done) {

    if ( err ) {
      return console.error( 'Connection error handled, code: ', err.code);
    }
    else {
      if ( client ) {
        console.error( 'Connection succeed on ', client.host );
      }
      else {
        console.error( 'Connection done but client is null or undefined' );
      }
    }
  });
}
catch( err ) {
  console.log( 'DB Connect error handled');
}

[vitaly-t]

+1000

The same error is thrown when we pass an invalid connection:

pg.connect("bla-bla");

Other than that, it is 100% reproducible for me, for both invalid user name and invalid password.

It's been way too long for such a critical issue to just sit here and nothing being done about it. Very frustrating.

I have a number of tests now for pg-promise commented out because of this error, which just kills jasmine framework that I'm using for testing.

Should have been labelled as a bug, at least, as it definitely is.

[brianc]

@vitaly-t The great thing about open source is if you're having frustration with something you can submit a patch & make the code better for everyone! I tried to reproduce the issue locally and wasn't able to and don't have time right now to dive deep into something that isn't causing me any issues and isn't reproducible on my end. Do you have the time to put together a pull request with a test and a fix for this?

The minimum code sample submitted by @kamushkin did not throw an error for me and the error was properly handled.

[vitaly-t]

@brianc, it's all doable, I'm just pressed for time, same as yourself, struggling to make time to maintain my own library :)

Anyhow, the issue here goes outside node-postgres, if you Google for it:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: read ECONNRESET
    at errnoException (net.js:901:11)
    at TCP.onread (net.js:556:19)

you will see how many people complain about the same error, just related to different libraries. The issue is within one of the sub-libraries that are used. I did take my time to narrow it down somehow, but without luck so far.

I don't understand how the issue doesn't manifest itself. I've tried it on 3 computers at this point, and can see it happen on each of them. Try reproducing the issue on other computers.

Also, as was pointed out earlier, the key tests for this are commented out, which is the key to showing the problem. Un-commenting those tests would be a good starting point.

[sehrope]

I'm not able to reproduce this either. I tried the sample code and it works fine with v4.3.0 on both my Mac and Linux desktop (Ubuntu 14.04). Both were run using only the JS bindings (not the native ones).