Bump packet-reader version #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the deprecation warning from using `new Buffer`.
charmander
reviewed
Feb 21, 2019
| @@ -17,9 +17,6 @@ matrix: | |||
| - node_js: "10" | |||
| addons: | |||
| postgresql: "9.6" | |||
| - node_js: "11" | |||
There was a problem hiding this comment.
Removed intentionally?
|
yah - it was breaking everyone's PR & AFAIK "odd" version numbers of node
are somewhat a moving target until they get closer to lts. The native
bindings aren't building on node@11 and I wont have time to look at that
for quite a while. C++ is not my favorite thing to dance with.
…On Wed, Feb 20, 2019 at 7:29 PM Charmander ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#1840 (comment)>:
> @@ -17,9 +17,6 @@ matrix:
- node_js: "10"
addons:
postgresql: "9.6"
- - node_js: "11"
Removed intentionally?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1840 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADDoSJwNyTvFxhTCpv9GObN4oAFKoitks5vPfZ8gaJpZM4bF7Px>
.
|
|
@brianc Interesting, it used to work a while ago. What this means though is that when 12 comes around it won't work either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the deprecation warning from using
new Buffer.closes #1811