Skip to content

Improve escapeLiteral performance of long strings by 30x #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve escapeLiteral performance of long strings by 30x #3553

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffcb4c1
Improve escapeIdentifier performance on long strings by 47x
Llorx Oct 3, 2025
b0db0c1
Use both escape versions depending on string length
Llorx Oct 3, 2025
6896bc9
Reduce the short string cap
Llorx Oct 3, 2025
6683d75
Simplify escapeLiteral and remove trailing spaces
Llorx Oct 6, 2025
8648279
Simplify escapeLiteral
Llorx Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 8 additions & 27 deletions packages/pg/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,36 +173,17 @@
}

const escapeLiteral = function (str) {
let hasBackslash = false
let escaped = "'"

if (str == null) {
return "''"
}

if (typeof str !== 'string') {
return "''"
}

for (let i = 0; i < str.length; i++) {
const c = str[i]
if (c === "'") {
escaped += c + c
} else if (c === '\\') {
escaped += c + c
hasBackslash = true
} else {
escaped += c
}
}

escaped += "'"

if (hasBackslash === true) {
escaped = ' E' + escaped
}

return escaped
let hasBackslash = false
let escaped = str

Check failure on line 180 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

'escaped' is never reassigned. Use 'const' instead
.replace(/\\/g, () => {

Check failure on line 181 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `··`
hasBackslash = true

Check failure on line 182 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `····`
return '\\\\'

Check failure on line 183 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Replace `··········` with `······`
})

Check failure on line 184 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `··`
.replace(/'/g, "''")

Check failure on line 185 in packages/pg/lib/utils.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `··`
return hasBackslash ? ` E'${escaped}'` : `'${escaped}'`
}

module.exports = {
Expand Down
Loading