Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asa: avoid repeated regex #545

Merged
merged 1 commit into from
Apr 11, 2024
Merged

asa: avoid repeated regex #545

merged 1 commit into from
Apr 11, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 11, 2024

  • The 1st two regex in run_file() handled empty lines and lines not starting with 1, 0, '+' or '-'; i.e. both regex were run together resulting in output of "\n"
  • Structure run_file() differently to avoid running every regex when a single lookup in a mapping table is good enough
  • The patched version appears to produce the same output as previous version

@mknos
asa: avoid repeated regex
fff0f8d 
* The 1st two regex in run_file() handled empty lines and lines not starting with 1, 0, '+' or '-'; i.e. both regex were run resulting in output of "\n"
* Structure run_file() differently to avoid running every regex when a single lookup in a mapping table is good enough
* The patched version appears to produce the same output as previous version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: asa The asa program labels Apr 11, 2024
@briandfoy briandfoy self-assigned this Apr 11, 2024
@briandfoy briandfoy merged commit 4f3daca into briandfoy:master Apr 11, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: asa The asa program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy