Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: refuse to process a directory #556

Merged
merged 1 commit into from
Apr 15, 2024
Merged

patch: refuse to process a directory #556

merged 1 commit into from
Apr 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 15, 2024

  • When testing against GNU patch, the following usage is invalid: "patch . < some.diff"
  • An error is displayed: "File . is not a regular file -- refusing to patch"
  • Even with patch -f (force) option the usage is not allowed
  • Add extra branch to condition where file-exists check happens to handle this

@mknos
patch: refuse to process a directory
4959d04 
* When testing against GNU patch, the following usage is invalid: "patch . < some.diff"
* An error is displayed: "File . is not a regular file -- refusing to patch"
* Even with patch -f (force) option the usage is not allowed
* Add extra branch to condition where file-exists check happens to handle this
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Apr 15, 2024
@briandfoy briandfoy self-assigned this Apr 15, 2024
@briandfoy briandfoy merged commit acc9877 into briandfoy:master Apr 15, 2024
1 of 2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 15, 2024
@briandfoy
Copy link
Owner

changes: only process regular files, and die otherwise

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy