Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: runtime error on empty file #560

Merged
merged 1 commit into from
Apr 16, 2024
Merged

ed: runtime error on empty file #560

merged 1 commit into from
Apr 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Apr 16, 2024

  • Fix the assumption in edEdit() that >0 bytes will be read from input file; it might be empty
  • Error discovered with "perl ed some.txt" then "1r EMPTYFILE" ... Modification of non-creatable array value attempted, subscript -1 at ed line 722.
  • Follow GNU ed and print the number of characters read (0)
  • I found that the default calculation of $CurrentLineNum was correct for all cases of insert mode, so use that

@mknos
ed: runtime error on empty file
1818778 
* Fix the assumption in edEdit() that >0 bytes will be read from input file; it might be empty
* Error discovered with "perl ed some.txt" then "1r EMPTYFILE" ... Modification of non-creatable array value attempted, subscript -1 at ed line 722.
* Follow GNU ed and print the number of characters read (0)
* The default calculation of $CurrentLineNum was correct for all cases of insert mode, so use that
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Apr 16, 2024
@briandfoy briandfoy self-assigned this Apr 16, 2024
@briandfoy briandfoy merged commit c825726 into briandfoy:master Apr 16, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: fixed inserting an empty file; print the number of characters read from a file

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Apr 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy