Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: increase strictness #674

Merged
merged 1 commit into from
Jul 20, 2024
Merged

diff: increase strictness #674

merged 1 commit into from
Jul 20, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 20, 2024

  • Strict was disabled within Algorithm::Diff::import() which was importing diff() function into the main namespace
  • I gave up converting import() to strict because the code was a bit magical
  • Settle for removing import() entirely and calling fully qualified Algorithm::Diff::diff()
  • Now the entire program can run under strict mode

@mknos
diff: increase strictness
b62c0a6 
* Strict was disabled within Algorithm::Diff::import() which was importing diff() function into the main namespace
* I gave up converting import() to strict because the code was a bit magical
* Settle for removing import() entirely and calling fully qualified Algorithm::Diff::diff()
* Now the entire program can run under strict mode
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: diff The diff program labels Jul 20, 2024
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:33 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 20, 2024 12:34 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10020226060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10011163182: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit 68bd65a into briandfoy:master Jul 20, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 20, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 20, 2024
@briandfoy briandfoy added Type: modernization updating programs to current practices and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Jul 20, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: diff The diff program Status: released there is a new release with this fix Type: modernization updating programs to current practices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy