Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp: warn for source directory #679

Merged
merged 1 commit into from
Jul 23, 2024
Merged

cp: warn for source directory #679

merged 1 commit into from
Jul 23, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 23, 2024

  • When running on non-unix, avoid passing a directory to File::Copy::copy() and print a helpful warning message
  • GNU and OpenBSD versions print a warning for this case too

@mknos
cp: warn for source directory
9245c19 
* When running on non-unix, avoid passing a directory to File::Copy::copy() and print a helpful warning message
* GNU and OpenBSD versions print a warning for this case too
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cp The cp command labels Jul 23, 2024
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 23, 2024 11:22 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10057971990

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Files with Coverage Reduction New Missed Lines %
bin/units 3 71.21%
Totals Coverage Status
Change from base Build 10034554410: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

briandfoy
briandfoy approved these changes Jul 23, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but if we ever add -r, it will be a problem.

@briandfoy briandfoy merged commit f486dc6 into briandfoy:master Jul 23, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 23, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 23, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jul 23, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cp The cp command Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy