Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: unused function #686

Merged
merged 1 commit into from
Jul 29, 2024
Merged

diff: unused function #686

merged 1 commit into from
Jul 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jul 29, 2024

  • Algorithm::Diff::LCS() was never called, and I am doubtful that the code would be correct
  • Declaring EXPORT_OK in Algorithm::Diff is also not needed, because the program doesn't explicitly import
  • Correct a comment that actually referred to the function Algorithm::Diff::diff()
  • As a regression test I ran "perl diff -e" then "patch -e" against the output

@mknos
diff: unused function
f67ac44 
* Algorithm::Diff::LCS() was never called, and I am doubtful that the code would be correct
* Declaring EXPORT_OK in Algorithm::Diff is not required too, because the program doesn't do explicit import
* Correct a comment that actually referred to the function Algorithm::Diff::diff()
* As a regression test I ran "perl diff -e" then "patch -e" against the output
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: diff The diff program labels Jul 29, 2024
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing July 29, 2024 02:10 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jul 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10136890544

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10134783857: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit 1158a23 into briandfoy:master Jul 29, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Jul 29, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Jul 29, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jul 29, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: diff The diff program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy