Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: chdir happens too late #718

Merged
merged 1 commit into from
Aug 14, 2024
Merged

patch: chdir happens too late #718

merged 1 commit into from
Aug 14, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 14, 2024

  • When testing against GNU and OpenBSD patch commands I found that -d DIR in this version is interpreted after reading a patch file

  • The standard says -d is interpreted "before processing" [1]

  • Follow the other versions of patch and do chdir() as early as possible:
    A) Failure to chdir() will terminate the program before any input is read
    B) If -d option is used, files in the argument list are relative to that directory not to the originating directory

  • test1: "perl patch -d ... a.c" --> fail (no such dir)

  • test2: "patch -d .. a.c a.diff" --> patch ../a.c with ../a.diff

  1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html

@mknos
patch: chdir happens too late
10adf2f 
* When testing against GNU and OpenBSD patch commands I found that -d DIR in this version is interpreted after reading a patch file
* The standard says -d is interpreted "before processing" [1]
* Match the other versions of patch and do chdir() as early as possible:
A) Failure to chdir() will terminate the program before any input is read
B) If -d option is used, files in the argument list are relative to that directory not to the originating directory
* test1: "perl patch -d ... a.c" --> fail: no such dir
* test2: "patch -d .. a.c a.diff" --> patch ../a.c with ../a.diff

1. https://pubs.opengroup.org/onlinepubs/007904975/utilities/patch.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Aug 14, 2024
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:43 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 00:44 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10379421930

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10369968527: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Aug 14, 2024
@briandfoy briandfoy merged commit b65ef57 into briandfoy:master Aug 14, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -d DIR now happens before processing, as it should

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 14, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy