Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: reject negative --fuzz value #719

Merged
merged 1 commit into from
Aug 14, 2024
Merged

patch: reject negative --fuzz value #719

merged 1 commit into from
Aug 14, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 14, 2024

  • Fail as early as possible if a negative number was given for --fuzz option
  • Getopt::Long already validates --fuzz argument as a number, but a negative value was previously ignored (the default of 2 would be used)
  • Found when testing against GNU patch

@mknos
patch: reject negative --fuzz value
c08aef5 
* Fail as early as possible if a negative number was given for --fuzz option
* Previously a negative value would be ignored and the default of 2 would be used
* Found when testing against GNU patch
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Aug 14, 2024
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 14, 2024 03:19 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10380839777

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10379500773: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Aug 14, 2024
@briandfoy
Copy link
Owner

changes: --fuzz argument must be a positive number

@briandfoy briandfoy merged commit f3912e6 into briandfoy:master Aug 14, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 14, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 14, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy