Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: allow --output to stdout #721

Merged
merged 1 commit into from
Aug 15, 2024
Merged

patch: allow --output to stdout #721

merged 1 commit into from
Aug 15, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 15, 2024

  • Allow '-' to be interpreted as standard out for -o option (aka --output); this works for Linux and OpenBSD versions
  • GNU diff writes notifications to stderr so they aren't jumbled with patch output; update note() to follow this
  • When writing to standard out, don't check if there's a file called '-' in current directory because it is not correct to make a backup by renaming it

@mknos
patch: allow --output to stdout
e77b29b 
* Allow '-' to be interpreted as standard out for -o option (aka --output); this works for Linux and OpenBSD versions
* GNU diff writes notifications to stderr so they aren't jumbled with patch output; update note() to follow this
* When writing to standard out, don't check if there's a file called '-' in current directory because it is not correct to make a backup by renaming it
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Aug 15, 2024
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 08:59 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 15, 2024 09:00 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10401395003

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10394346456: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 33de1ec into briandfoy:master Aug 15, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Aug 15, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 15, 2024
@briandfoy
Copy link
Owner

briandfoy commented Aug 15, 2024 •
edited
Loading

changes: with --output, use - to send output to standard output

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy