Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basename: support -- option terminator #723

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 16, 2024

  • Similar to what was committed for bin/dirname, '--' should be interpreted as the end of options (currently it is taken literally)
  • This was found when testing against OpenBSD version
  • test1: "perl basename --" --> error, no argument
  • test2: "perl basename -x" --> error, bad option
  • test3: "perl basename -- -x" --> basename of "-x"
  • While here, one call to usage() in bin/dirname was missed

mknos added 2 commits August 16, 2024 14:27
* Similar to what was committed for bin/dirname, '--' should be interpreted as the end of options (currently it is taken literally)
* This was found when testing against OpenBSD version
* test1: "perl basename --" --> error, no argument
* test2: "perl basename -x" --> error, bad option
* test3: "perl basename -- -x" --> basename of "-x"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: basename The base name program Program: dirname The dirname program labels Aug 16, 2024
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 16, 2024 06:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 16, 2024

Pull Request Test Coverage Report for Build 10423928136

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%

Files with Coverage Reduction New Missed Lines %
bin/units 3 70.77%
Totals Coverage Status
Change from base Build 10407100403: -0.7%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

@briandfoy briandfoy self-assigned this Aug 16, 2024
@briandfoy
Copy link
Owner

changes: accept -- as end of options

@briandfoy briandfoy closed this Aug 16, 2024
@briandfoy briandfoy reopened this Aug 16, 2024
@briandfoy briandfoy merged commit 49a1bac into briandfoy:master Aug 16, 2024
27 of 28 checks passed
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:36 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:36 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 16, 2024
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy temporarily deployed to automated_testing August 16, 2024 17:37 — with GitHub Actions Inactive
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: basename The base name program Program: dirname The dirname program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants