Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moo: quit on EOF #725

Merged
merged 1 commit into from
Aug 19, 2024
Merged

moo: quit on EOF #725

merged 1 commit into from
Aug 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 19, 2024

  • When prompted for a guess, "q" terminates the program
  • If stdin is attached to a file/pipe, or I run moo interactively and hit ctrl-d I observe a repeated prompt
  • The least confusing thing is to act like a "q" command was seen and terminate the program
  • test: "ifconfig | perl moo" --> series of "bad guess" messages then the program ends

@mknos
moo: quit on EOF
902ce56 
* When prompted for a guess, "q" terminates the program
* If stdin is attached to a file/pipe, or I run moo interactively and hit ctrl-d I observe a repeated prompt
* The least confusing thing is to act like a "q" command was seen and terminate the program
* test: "ifconfig | perl moo" --> series of "bad guess" messages then the program ends
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Aug 19, 2024
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@github-actions github-actions bot added the Program: moo The moo program label Aug 19, 2024
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 19, 2024 13:56 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10454749585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10445725504: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Aug 19, 2024
@briandfoy briandfoy merged commit 57c92da into briandfoy:master Aug 19, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: quit on q or empty input

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 9, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: moo The moo program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy