Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: -t lists files not in archive #727

Merged
merged 1 commit into from
Aug 28, 2024
Merged

ar: -t lists files not in archive #727

merged 1 commit into from
Aug 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 28, 2024 •
edited
Loading

  • The -t option lists all archive members by default, otherwise only the files specified as arguments
  • printList() was incorrectly printing a name that was not found in the archive
  • binutils ar prints a warning in this case (printMember() follows this but printList() did not)
%perl ar -t test.a # test archive contains 2 files
words
wordlist.txt.old
%perl ar -t test.a words words2 # output indicates words2 exists in archive
words
words2
%ar -t test.a words words2 # binutils comparison
words
no entry words2 in archive

@mknos
ar: -t lists files not in archive
bd5b22a 
* The -t option lists all archive members by default, otherwise only the files specified as arguments
* printList() was incorrectly printing a name that was not found in the archive
* binutils ar prints a warning in this case (printMember() follows this but printList() did not)

%perl ar -t test.a # test archive contains 2 files
words
wordlist.txt.old
%perl ar -t test.a words words2 # output indicates words2 exists in archive
words
words2
%ar -t test.a words words2 # binutils comparison
words
no entry words2 in archive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Aug 28, 2024
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 28, 2024 07:38 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10592307180

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10520457529: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 72ef7fd into briandfoy:master Aug 28, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -t correctly reports missing members now

@briandfoy briandfoy self-assigned this Aug 28, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Aug 28, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy