Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: binmode for writing archives #728

Merged
merged 1 commit into from
Aug 30, 2024
Merged

ar: binmode for writing archives #728

merged 1 commit into from
Aug 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 29, 2024

  • I noticed there were 4 calls to FileHande->new() to open files, but only 3 calls to binmode()
  • The function missing the binmode() call was writeAr(); this is responsible for writing a modified archive to disk, or creating a brand new archive
  • Archives are allowed to contain binary files so enabling binmode() here seems like a good idea
  • I didn't test this on Windows but I didn't see any regression with patch applied on Linux
%cc a.c
%perl ar -qv A.a a.out # create new archive with just the binary a.out
a - a.out

@mknos
ar: binmode for writing archives
7ebea24 
* I noticed there were 4 calls to FileHande->new() to open files, but only 3 calls to binmode()
* The function missing the binmode() call was writeAr(); this is responsible for writing a modified archive to disk, or creating a brand new archive
* Archives are allowed to contain binary files so enabling binmode() here seems like a good idea
* I didn't test this on Windows but I didn't see any regression with patch applied on Linux
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Aug 29, 2024
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 29, 2024 11:17 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10613992135

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10595804740: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10613992135

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.805%
Totals Coverage Status
Change from base Build 10595804740: 0.0%
Covered Lines: 355
Relevant Lines: 481
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10613992135

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10595804740: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Aug 30, 2024
@briandfoy briandfoy merged commit 5325cb9 into briandfoy:master Aug 30, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: all fils are treated as binary now

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 30, 2024
@briandfoy briandfoy self-assigned this Aug 30, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy