Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: best-effort extract & delete #729

Merged
merged 1 commit into from
Sep 1, 2024
Merged

ar: best-effort extract & delete #729

merged 1 commit into from
Sep 1, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 30, 2024

  • If extracting or deleting multiple archive members, process all arguments even if some members are not found
  • This patch follows how binutils version works
%ar -t test2.a # list archive members
words
wordlist.txt.ol
%ar -xv test2.a not1 not2 words # extract 3 files (1 is extracted)
no entry not1 in archive
no entry not2 in archive
x - words
%ar -dv test2.a test test2 words # delete 3 files (1 is deleted)
No member named `test'
No member named `test2'
d - words

@mknos
ar: best-effort extract & delete
2b014da 
* If extracting or deleting multiple archive members, process all arguments even if some members are not found
* This patch follows how binutils version works

%ar t test2.a
words
wordlist.txt.ol
%ar -xv test2.a not1 not2 words 
no entry not1 in archive
no entry not2 in archive
x - words
%ar -dv test2.a test test2 words
No member named `test'
No member named `test2'
d - words
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Aug 30, 2024
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 30, 2024 08:02 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10629054953

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10625086580: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Sep 1, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Sep 1, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Sep 1, 2024
@briandfoy briandfoy merged commit 7f4d235 into briandfoy:master Sep 1, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: extract/delete all arguments even if some members are not found

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy