Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwd: don't raise error for -- terminator #731

Merged
merged 1 commit into from
Sep 5, 2024
Merged

pwd: don't raise error for -- terminator #731

merged 1 commit into from
Sep 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 4, 2024

  • This version of pwd already acted like the BSD version because it would raise an error if any non-option arguments are provided
  • When testing against OpenBSD, the usage pwd -L -- is valid; this version raised an error because '--' was interpreted as an argument instead of option terminator
  • getopts() handles -- internally, so switch over to it as done in other scripts

@mknos
pwd: don't raise error for -- terminator
99075c7 
* This version of pwd already acted like the BSD version because it would raise an error if any non-option arguments are provided
* When testing against OpenBSD, the usage pwd -L --" is valid; this version raised an error because '--' was interpreted as an argument instead of option terminator
* getopts() handles -- internally, so switch over to it as done in other scripts
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: pwd The pwd program labels Sep 4, 2024
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 4, 2024 05:21 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10695589569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 10656122481: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Sep 5, 2024
@briandfoy
Copy link
Owner

changes: allow --, even though there are no arguments

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 5, 2024
@briandfoy briandfoy merged commit 1aa895d into briandfoy:master Sep 5, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: pwd The pwd program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy