-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addbib: correctly re-open database #734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Sep 9, 2024
- I discovered the cause of the close() error I was seeing when editing a database entry with vi, then hitting y to continue
- When continuing a new entry is expected to be appended to the database
- The file was closed and re-opened between executing vi; however, due to the "my" declaration in the open() call an alias of the global filehandle $DATABASE was made
- Make sure there is only one $DATABASE variable; now I can correctly append new entries after editing an entry with vi
* I discovered the cause of the close() error I was seeing when editing a database entry with vi, then hitting y to continue * When continuing a new entry is expected to be appended to the database * The file was closed and re-opened between executing vi; however, due to the "my" declaration in the open() call an alias of the global filehandle $DATABASE was made * Make sure there is only one $DATABASE variable; now I can correctly append new entries after editing an entry with vi
Pull Request Test Coverage Report for Build 10765406861Details
💛 - Coveralls |
briandfoy
approved these changes
Sep 9, 2024
changes: fix database re-opening that was masking a lexical variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: addbib
The addbib program
Status: released
there is a new release with this fix
Type: bug
an existing feature does not work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.