Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

col: retire options -E/-e #735

Merged
merged 1 commit into from
Sep 13, 2024
Merged

col: retire options -E/-e #735

merged 1 commit into from
Sep 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 12, 2024

  • By default both types of escapes are supported
  • Standard col provides no flag for disabling particular escapes [1], so it's not necessary here either
  • BSD versions of col support both types of escapes so follow that [2] [3] [4]
  • BSD versions support a greater number of escapes than this version, but more escapes could be added here later
  • Sync usage string and POD document now that -E and -e are gone; extension options -s and -t remain
  • Bump version number
  1. https://pubs.opengroup.org/onlinepubs/7990989799/xcu/col.html
  2. https://man.freebsd.org/cgi/man.cgi?query=col&apropos=0&sektion=0&manpath=FreeBSD+14.1-RELEASE+and+Ports&arch=default&format=html
  3. https://man.netbsd.org/col.1
  4. http://man.openbsd.org/col

* By default both types of escapes are supported
* Standard col provides no flag for disabling particular escapes [1], so it's not necessary here either
* BSD versions of col support both types of escapes so follow that [2] [3] [4]
* BSD versions support a greater number of escapes than this version, but more escapes could be added here later
* Bump version number

1. https://pubs.opengroup.org/onlinepubs/7990989799/xcu/col.html
2. https://man.freebsd.org/cgi/man.cgi?query=col&apropos=0&sektion=0&manpath=FreeBSD+14.1-RELEASE+and+Ports&arch=default&format=html
3. https://man.netbsd.org/col.1
4. http://man.openbsd.org/col
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: col The col program labels Sep 12, 2024
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:34 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 12, 2024 11:35 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build 10829971514

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%

Totals Coverage Status
Change from base Build 10771400209: -0.7%
Covered Lines: 350
Relevant Lines: 479

💛 - Coveralls

Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should accept the -e and -E as legacy options and simply do nothing with them. If someone is already using them, they don't get an error. Thoughts?

@mknos
Copy link
Contributor Author

mknos commented Sep 13, 2024

If other versions of col had -e/-E options it might be worth keeping these as compat stubs, but I can't find any versions that have it. On Linux I have "col from util-linux 2.36.1", which doesn't have it. It's not documented on AIX, Solaris or Plan9 either, so unix users would not be familiar with these options. I prefer keeping the patch as is.

https://www.ibm.com/docs/fi/aix/7.1?topic=c-col-command
https://shrubbery.net/solaris9ab/SUNWaman/hman1/col.1.html
https://9fans.github.io/plan9port/man/man1/col.html

@briandfoy briandfoy merged commit 40cdfce into briandfoy:master Sep 13, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Sep 13, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Sep 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy added Type: compatability make it work like GNU or BSD and removed Type: enhancement improve a feature that already exists labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: col The col program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants