-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
col: retire options -E/-e #735
Conversation
mknos
commented
Sep 12, 2024
- By default both types of escapes are supported
- Standard col provides no flag for disabling particular escapes [1], so it's not necessary here either
- BSD versions of col support both types of escapes so follow that [2] [3] [4]
- BSD versions support a greater number of escapes than this version, but more escapes could be added here later
- Sync usage string and POD document now that -E and -e are gone; extension options -s and -t remain
- Bump version number
- https://pubs.opengroup.org/onlinepubs/7990989799/xcu/col.html
- https://man.freebsd.org/cgi/man.cgi?query=col&apropos=0&sektion=0&manpath=FreeBSD+14.1-RELEASE+and+Ports&arch=default&format=html
- https://man.netbsd.org/col.1
- http://man.openbsd.org/col
* By default both types of escapes are supported * Standard col provides no flag for disabling particular escapes [1], so it's not necessary here either * BSD versions of col support both types of escapes so follow that [2] [3] [4] * BSD versions support a greater number of escapes than this version, but more escapes could be added here later * Bump version number 1. https://pubs.opengroup.org/onlinepubs/7990989799/xcu/col.html 2. https://man.freebsd.org/cgi/man.cgi?query=col&apropos=0&sektion=0&manpath=FreeBSD+14.1-RELEASE+and+Ports&arch=default&format=html 3. https://man.netbsd.org/col.1 4. http://man.openbsd.org/col
Pull Request Test Coverage Report for Build 10829971514Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should accept the -e and -E as legacy options and simply do nothing with them. If someone is already using them, they don't get an error. Thoughts?
If other versions of col had -e/-E options it might be worth keeping these as compat stubs, but I can't find any versions that have it. On Linux I have "col from util-linux 2.36.1", which doesn't have it. It's not documented on AIX, Solaris or Plan9 either, so unix users would not be familiar with these options. I prefer keeping the patch as is. https://www.ibm.com/docs/fi/aix/7.1?topic=c-col-command |