Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on ruby-head, allow failures #665

Merged
merged 1 commit into from
Sep 10, 2015
Merged

Conversation

sodabrew
Copy link
Collaborator

@sodabrew sodabrew commented Sep 6, 2015

@tamird @cbandy The query timeout workaround is failing on the uninitialized constant Timeout::ExitException in ruby-head. I wonder if they renamed this upstream!? I'll be sorting through https://github.com/ruby/ruby/blob/trunk/lib/timeout.rb soon...

https://travis-ci.org/sodabrew/mysql2/jobs/79014190

@sodabrew
Copy link
Collaborator Author

sodabrew commented Sep 6, 2015

Yep: ruby/ruby@0f663b2

@tamird
Copy link
Contributor

tamird commented Sep 6, 2015

Sigh. Easy enough to solve by defining an alias at load-time.

@sodabrew sodabrew added this to the 0.4.1 milestone Sep 6, 2015
@cbandy
Copy link
Contributor

cbandy commented Sep 6, 2015

Maybe it's because I wasn't paying attention to the initial implementation...

Aren't there other places where interrupts can affect the protocol state? Are there some defines that help us do this around specific C calls in the extension?

@sodabrew
Copy link
Collaborator Author

sodabrew commented Sep 6, 2015 via email

@jeremy
Copy link
Contributor

jeremy commented Sep 7, 2015

Just hit this upgrading Active Record to support 0.4.0 (we test on Ruby trunk, too).

@jeremy
Copy link
Contributor

jeremy commented Sep 7, 2015

Note that the ExitException removal was backported, too, but with an alias for compatibility: ruby/ruby@4027090#diff-32f7163092f0e8e64a3936fba1a3d59dR47

@tamird
Copy link
Contributor

tamird commented Sep 8, 2015

@jeremy sadly that won't help here as this library still supports all the way back to 1.8.7 (though the relevant versions are those that support Thread.handle_interrupt and don't have the backport: 2.0 and 2.1).

@jeremy
Copy link
Contributor

jeremy commented Sep 8, 2015

@tamird Right, the backports only demonstrate that aliasing ExitException = Error is the way to go. See #671 😁

@sodabrew sodabrew merged commit b1ca5cb into brianmario:master Sep 10, 2015
@sodabrew sodabrew deleted the ruby_head branch September 10, 2015 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants