Fix test that implicitly creates a passwordless user #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,7 +200,7 @@ def run_gc | |||
| it "should be able to connect to database with numeric-only name" do | |||
| creds = DatabaseCredentials['numericuser'] | |||
| @client.query "CREATE DATABASE IF NOT EXISTS `#{creds['database']}`" | |||
| @client.query "GRANT ALL ON `#{creds['database']}`.* TO #{creds['username']}@`#{creds['host']}`" | |||
| @client.query "GRANT ALL ON `#{creds['database']}`.* TO #{creds['username']}@`#{creds['host']}` IDENTIFIED BY '#{creds['password']}'" | |||
jeremy
force-pushed
the
fix-grant-with-no-auto-create-user
branch
from
ac2c2dc to
48f2164
Compare
| @@ -7,11 +7,11 @@ root: | |||
| user: | |||
| host: localhost | |||
| username: LOCALUSERNAME | |||
| password: | |||
| password: test | |||
There was a problem hiding this comment.
The default travis user has no password: http://docs.travis-ci.com/user/database-setup/#MySQL
I'm not sure how the tests pass with this change?
There was a problem hiding this comment.
These config are only for specs. We only connect as root.
In fact, the user config is unused and, according to git history, has never been used!
IMO the numericuser config is inappropriate here too. The spec should use the same config and just change the db name to a numeric one.
There was a problem hiding this comment.
Updated to drop the unused toplevel db configs. The numeric-db spec should just create the numeric db using the main test db creds. Much simpler!
When the MySQL server has NO_AUTO_CREATE_USER, a GRANT can't implicitly create a user unless a password is specified. To fix, just provide a dummy password in the example db config and update the GRANT.
…in the spec. Drop the never-used 'user' db config.
jeremy
force-pushed
the
fix-grant-with-no-auto-create-user
branch
from
48f2164 to
a08b491
Compare
|
Resolved by 39901da |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the MySQL server has
NO_AUTO_CREATE_USER, a GRANT can't implicitlycreate a user unless a password is specified. To fix, just provide a
dummy password in the example db config and update the GRANT.