Wait for close to be processed by server in test for Threads_connected #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
reviewed
May 24, 2017
spec/mysql2/client_spec.rb
Outdated
| end | ||
| }.to_not change { | ||
| @client.query("SHOW STATUS LIKE 'Aborted_%'").to_a + | ||
| @client.query("SHOW STATUS LIKE 'Threads_connected'").to_a |
There was a problem hiding this comment.
Threads_connected should change, huh?
Perhaps we should just check that the client connection wasn't aborted. The SHOW PROCESSLIST check is already demonstrating that the client is no longer connected, which is the aim of the spec.
There was a problem hiding this comment.
Threads_connectedshould change, huh?
It should not change as the }.to_not change { line specifies, since the client was opened and closed in the expect block.
Sure, I could just check that it hasn't aborted here, which should hopefully also make this test likely to fail due to some connection from another test being closed by the garbage collector during the expect block.
There was a problem hiding this comment.
Pushed this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As discussed in #848 (comment), the test I am changing fails in a flaky way due to
mysql_closesending a quit command without waiting for a response, so the following query for the Threads_connected can return a count that includes the connection that was been closed on the client side.Solution
Give the server a second to detect and response to the client closing the connection by using the
SHOW PROCESSLISTcommand to check if the server still thinks the client is connected.I wrapped the contents of the test in a loop as I commented in #848 (comment) to confirm that this deals with this type of flaky test failure.