Avoid Errors in Internet Explorer 8 if jQuery isn't loaded #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If jQuery is not loaded before sifter this line previously failed in Internet Explorer 8 with the message "'$' is undefined" instead of using the fallback function.
lucash
added a commit
to lucash/sifter.js
that referenced
this pull request
Oct 23, 2015
Please see this Pull Request to check if this is merged: brianreavis#34
brianreavis
added a commit
that referenced
this pull request
Oct 23, 2015
Avoid Errors in Internet Explorer 8 if jQuery isn't loaded
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If jQuery is not loaded before sifter this line previously failed in
Internet Explorer 8 with the message "'$' is undefined" instead of using
the fallback function.