Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change csv dependency to use an npm-available parser #45

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

kiara-riley
Copy link
Contributor

Hey @brianreavis,

We have had some issues lately with the way this csv dependency works. Especially behind proxies and what not. This just changes the dependency to use another parser that is accessible through npm.

I ran the tests, they were fine and I got the same results when running the csv commands you have in your README.md.

Let me know if I need to change anything here.

@coveralls
Copy link

coveralls commented Sep 15, 2016

Coverage Status

Coverage remained the same at 93.434% when pulling 035f9ad on kraigmckernan:master into 59d61ce on brianreavis:master.

@brianreavis brianreavis merged commit a6c34f8 into brianreavis:master Sep 15, 2016
@brianreavis
Copy link
Owner

Thanks Kraig – I think this'll make a lot of people happy. Looks great to me. Off topic: cool seeing other people in Bozeman on GitHub!

@brianreavis
Copy link
Owner

Released 0.5.2

@kiara-riley
Copy link
Contributor Author

Thanks for the quick turnaround, our build is working again!

Yeah I was yelling out my window to see if you would fix it for us but you must not have heard me!

@rliota
Copy link

rliota commented Sep 21, 2016

Thanks @kraigmckernan and @brianreavis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants