Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get storybook to run and npm audit #135

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

konsumer
Copy link
Contributor

@konsumer konsumer commented May 21, 2021

This is a npm audit (only fixed 2/24 vulns, so more manual fixes should be applied) and makes storybook work out of the box (clone repo, run npm i, then npm run storybook)

I didn't fix anything with #134 so I still needed the --legacy-peer-deps flag.

@konsumer
Copy link
Contributor Author

Maybe it would be better to keep "type": "module" and fix the require('path') in .storybook/main.js?

@konsumer
Copy link
Contributor Author

Just renaming main.js to main.cjs seems to fix it, while keeping "type": "module"

Copy link
Owner

@brianzinn brianzinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @konsumer - i always manually build storybook before running. intention is to move storybook into a subdirectory with own package.json as most of those dev dependencies have no bearing on the main project itself :)

@brianzinn brianzinn merged commit eb7e4df into brianzinn:master May 21, 2021
@konsumer
Copy link
Contributor Author

intention is to move storybook into a subdirectory with own package.json as most of those dev dependencies have no bearing on the main project itself :)

Yeh, that is a good call. This is fairly minimal impact, for now, but that seems like a better solution.

@konsumer
Copy link
Contributor Author

I bet we could even replace ../../../dist/react-babylonjs with aliases so it can work as a standalone package, and also work in-tree, if you want them to still work together (which would be handier for adding new features to react-bablyonjs, as you will get full-rebuilds of the library, too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants