2 tests DataSourcePatterns class

[youphendriks]

Valid input working, invalid input Disabled cause I have to figure out how to throws.
getDataSourceMatches class does not throw an exception on following inputs; "", " "
Is there a different method to make my test throw an exception or is the problem the lack of exception handling in the codebase?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.95%. Comparing base (3c039ec) to head (5038cd5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   19.93%   19.95%   +0.01%     
==========================================
  Files         164      164              
  Lines       10542    10542              
  Branches     1403     1403              
==========================================
+ Hits         2102     2104       +2     
+ Misses       8245     8242       -3     
- Partials      195      196       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[egonw]

I don't think there is any code left from the previous session. Please update this line to just list your name. If you do prefer not to give your email address, you can use <youphendriks@github.com>, but likely your email address is in the git commit message anyway.

[egonw]

The first sentence of JavaDoc should always end with a period. Please add these.

[egonw]

See my comments.

[egonw]

Is there a different method to make my test throw an exception or is the problem the lack of exception handling in the codebase?

I need a bit more explanation here, because I am not sure what you mean.

[youphendriks]

Implemented changes: added "." to JavaDoc and changed name and email to mine. I believe this commit has been added to the PR, could you check?

[egonw]

Thanks, merged! I updated the copyright year (since you write it this year) and some formatting. We should have a template for the copyright/license header and then apply it to all files. Right now, many still are a mix of copyright/license and documentation (the last should be in the JavaDoc instead, in my opinion).

[youphendriks]

Good to know I should also update the copyright year, I was not sure if I should do this. I’ll set up a template and start making it uniform. Today I will work on implementing mockito, I’ll keep you posted!

…

________________________________ From: Egon Willighagen ***@***.***> Sent: Monday, March 4, 2024 6:41:02 AM To: bridgedb/BridgeDb ***@***.***> Cc: Youp Hendriks ***@***.***>; Author ***@***.***> Subject: Re: [bridgedb/BridgeDb] 2 tests DataSourcePatterns class (PR #237) Thanks, merged! I updated the copyright year (since you write it this year) and some formatting. We should have a template for the copyright/license header and then apply it to all files. Right now, many still are a mix of copyright/license and documentation (the last should be in the JavaDoc instead, in my opinion). — Reply to this email directly, view it on GitHub<#237 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK7FBZFRY57HCHILLM6C4S3YWQCO5AVCNFSM6AAAAABD6MDSYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVG43TCNJYGE>. You are receiving this because you authored the thread.Message ID: ***@***.***>