Update BDBVERSION in pom.xml #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, it's not supposed to use 3.1.x yet. But when I used
|
This reverts commit f080839.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 65.61% 65.61%
Complexity 138 138
=========================================
Files 21 21
Lines 791 791
Branches 108 108
=========================================
Hits 519 519
Misses 228 228
Partials 44 44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of BridgeDB used to build the new docker upon ping from the repo uses the following code to get the
BDBVERSION:https://github.com/bridgedb/docker/blob/fc06a5f214797e0b76a461fee4b7d99a4fe5ae21/.github/workflows/buildandpush.yml#L42C18-L42C92
Meaning this POM needs to be updated too. This patch fixes the issue for now, but what will the workflow be to automate this?