Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs-sidecar image reference is embedded in the code #35

Closed
bacongobbler opened this issue Oct 25, 2017 · 2 comments
Closed

vcs-sidecar image reference is embedded in the code #35

bacongobbler opened this issue Oct 25, 2017 · 2 comments

Comments

@bacongobbler
Copy link
Contributor

Issue by bacongobbler
2017-07-06 23:08:01


Right now acid embeds the vcs-sidecar image reference directly in the source code. Because I don't have the right credentials to pull this image, I need to build and push out my own vcs-sidecar image, modify the source code and then re-deploy acid. This doesn't bode well for a developer experience.

Would it be possible to somehow embed the vcs-sidecar process within acid? That way we don't have to reference and rely upon a separate docker image for all github push events.

@bacongobbler
Copy link
Contributor Author

Comment by technosophos
2017-07-07 20:58:44


We can probably set this in the chart and suck it out of an env var.

@bacongobbler
Copy link
Contributor Author

Comment by technosophos
2017-07-07 21:57:26


I started down the path of making this a global config option, only to realize that the most likely scenario is that this would be overridden per-project.

So right now, it's shaping up like this:

$ helm install acid-project --set vcsSidecar=myImage:myTag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant