Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old builds #7

Closed
bacongobbler opened this issue Oct 25, 2017 · 6 comments
Closed

Clean up old builds #7

bacongobbler opened this issue Oct 25, 2017 · 6 comments

Comments

@bacongobbler
Copy link
Contributor

Issue by technosophos
2017-04-20 22:40:22


Right now, each build creates at least one pod and one config map. Currently, for logging, these must persist "until the user is done with them" (e.g. until the logs are no longer relevant.

Really, we probably want to destroy the pod/configmap soon after it's run. But we can't really do this until we persist logging elsewhere

@bacongobbler
Copy link
Contributor Author

Comment by jchauncey
2017-04-21 21:52:28


I would make this an option. That way people can inspect that state of a failed build and see what went wrong.

@bacongobbler
Copy link
Contributor Author

Comment by bacongobbler
2017-07-04 23:22:55


We could add a configurable option like BUILD_HISTORY_LIMIT that limits the number of pod/configmap sets that are available to view from the most recent builds. That along with a plugin system to push logs offshore would ideally be the best of both worlds.

@bacongobbler
Copy link
Contributor Author

Comment by technosophos
2017-08-30 15:39:34


At this point, we are setting a timestamp on secrets to indicate when it is safe to clean them up, but we still aren't automating anything.

@u2takey
Copy link

u2takey commented Nov 2, 2017

Comment by u2takey
2017-11-02 15:39:54


Should we add cmd delete/remove on brigage-client? For now, adding a cmd : clearall, which clean all brigage-related resource, will be very helpful for developers.

@technosophos
Copy link
Contributor

The idea to make this a feature of brig is a great idea.

@technosophos
Copy link
Contributor

brigade-vacuum now does the time-based cleanup. Marking this as closed.

willie-yao pushed a commit to willie-yao/brigade that referenced this issue Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants