Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support no space before operator and left paren #15

Closed
wants to merge 2 commits into from
Closed

support no space before operator and left paren #15

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2017

NOT(text:go)

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 78.582% when pulling 99c3761 on uxnow:feature-nospace-between-operator-and-left-paren into c51f4e0 on bripkens:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage decreased (-1.1%) to 78.582% when pulling 99c3761 on uxnow:feature-nospace-between-operator-and-left-paren into c51f4e0 on bripkens:master.

@bripkens
Copy link
Owner

Your tests are not testing what you are describing in the message of your PR. Also, could you please also take care that the AST can be turned into the same string again via toString?

@ghost
Copy link
Author

ghost commented Nov 30, 2017

ok, I will look into the tests

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage increased (+0.04%) to 79.764% when pulling 932e792 on uxnow:feature-nospace-between-operator-and-left-paren into c51f4e0 on bripkens:master.

@ghost
Copy link
Author

ghost commented Nov 30, 2017

Is It better to convert NOT(text:go) to NOT (text:go)?

@bripkens
Copy link
Owner

it should preferably be exactly (or very closely) what the user typed in. Meaning in this case, it there is a space, then we should retain the space character.

@ghost
Copy link
Author

ghost commented Dec 1, 2017

I see, thank you for your explanation which reminds me some good ideas. I will close this pull request first, thank you again.

@ghost ghost closed this Dec 1, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants