Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local proxrox proxy config? #6

Closed
city41 opened this issue Jan 11, 2015 · 5 comments · Fixed by #8
Closed

local proxrox proxy config? #6

city41 opened this issue Jan 11, 2015 · 5 comments · Fixed by #8
Assignees

Comments

@city41
Copy link

city41 commented Jan 11, 2015

This is a great idea. Currently I am using nginx to proxy two micro services into one website during development. If proxrox read a local proxrox.json file or something like that, and could set up proxies on the fly based on that file, it'd be incredibly useful. Something like

{
  "/foo": "http://127.0.0.1:8000",
  "/bar": "http://127.0.0.1:9000"
}

obviously that's super simplified, but the general idea.

@bripkens
Copy link
Owner

Sounds good and I have been thinking about this as well. I see two things that need to be done:

  1. Possibility to load proxvox configs from the file system.
  2. Support proxies for subdirectories. How are you currently doing this? I would assume that you are using multiple location directives?

@bripkens
Copy link
Owner

I created issue #7 to track part 2 of this issue (proxies for subdirectories).

@city41
Copy link
Author

city41 commented Jan 11, 2015

Yeah my nginx.conf has multiple location directives in it.

My use case is one of my services is a RESTful API, and the other provides dynamic HTML. Otherwise I could just use a static directory for the HTML service.

I'm not sure how ultimately this should all look, where would the proxrox config file typically live? with one of the services? in ~/.proxrox/<name>.conf and then you invoke it with proxrox -c <name>? I have no idea, I'll definitely leave that kind of stuff to you :)

@bripkens bripkens self-assigned this Jan 12, 2015
bripkens added a commit that referenced this issue Jan 17, 2015
It is beneficial to share proxrox configurations within a team so that very
developer has the local development setup.

Proxrox configurations can follow webpack's and other tools best
practices, i.e. support JSON and YAML config format.

Fixes #6

Support loading of JSON and YAML config files

Support YAML and JSON comments

Accept config as an argument to proxrox start

Document changes

Document usage
bripkens added a commit that referenced this issue Jan 17, 2015
It is beneficial to share proxrox configurations within a team so that very
developer has the local development setup.

Proxrox configurations can follow webpack's and other tools best
practices, i.e. support JSON and YAML config format.

Fixes #6
bripkens added a commit that referenced this issue Jan 17, 2015
It is beneficial to share proxrox configurations within a team so that very
developer has the local development setup.

Proxrox configurations can follow webpack's and other tools best
practices, i.e. support JSON and YAML config format.

Fixes #6
@bripkens
Copy link
Owner

@city41: I will release a new version of proxrox later today. I would be happy if you could take a look at the changes and tell me whether they are sufficient for your use case. Thanks!

@bripkens
Copy link
Owner

@city41: FYI, I just released v1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants