Migrate attribute conversion #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idmarjr
added a commit
that referenced
this pull request
Nov 11, 2021
* Start webpack migration * Release version (#142) * Add new SVG logos (Round and Square) - Based in the original logo - SVG so we have more flexibility increasing size if needed * New public pages style (Login, Sign up) - Use Boorstrap markup to forms; - Add waves graph to add soome life to public pages; - Use Square SVG logo - Add more weight to <h1> font * Fix form name and css error class * Show waves background only in public pages * Adjust accessiblity outline to match product color [ ! ] Keep in mind this is an acessibility feature and we need to be careful when removing/changing this kind of behaviour - Remove outline from button, input type button and type submit; - Use box shadow to emulate ottline behaviour instead; - Add transition to box shadow * Add transition to .form-control:focus Co-authored-by: Idmar Ramos Junior (Id) <idmarjr@gmail.com> * Release version (#148) * Add new SVG logos (Round and Square) - Based in the original logo - SVG so we have more flexibility increasing size if needed * New public pages style (Login, Sign up) - Use Boorstrap markup to forms; - Add waves graph to add soome life to public pages; - Use Square SVG logo - Add more weight to <h1> font * Fix form name and css error class * Show waves background only in public pages * Adjust accessiblity outline to match product color [ ! ] Keep in mind this is an acessibility feature and we need to be careful when removing/changing this kind of behaviour - Remove outline from button, input type button and type submit; - Use box shadow to emulate ottline behaviour instead; - Add transition to box shadow * Add transition to .form-control:focus * Add Google Analytics tracking code * Fix indentation Co-authored-by: Milton Bittencourt <miltonbst@gmail.com> * Creates the initial webpack config * Exporting angularjs components as module and a modal example * Add dist to .gitignore * login component cleanup * Inject dependency properly * Create new dropdown component * Adapt modals to work with components and webpack * Create workspace module component * Add module cors to work with separed servers * Adapt modelAPI to webpack * Delete unused files * Replace dropdown directive for new component * Wrapup new workspace module component * Changes the style files imports in order to fix wrong font style * Configures react2angular and migrates the Login button to a React component * Allows jsx extensions * Fix fontawsome import * Configures the HtmlWebpackPlugin * Create <div class=modal-header> * Create createModelModal component * Create deleteModelModal component * Create renameModelModal component * Inject new modal components * Import and inject new components * Reorganize imports in order to improve performance * Clean unused files * Update README.md - Add yarn to dependencies section - Change npm to yarn commands - Change localhost port to 3000 to 9000 * Fix workspace header * Starting conceptual componetization * Fix drag and drop issues * Finish drag and drog deature * Link commands * Conceptual - load saved model * Conceptual - save model * Conceptual - duplicate model * Conceptual - conversion call * Conceptual - apply halo * Configure jest to run with angular * Create erd factory module * Create erd validator module * Create erd linker module * Refactoring to use modules * Testing erd factory module * Update .gitignore * Increase coverge linker.js * Fix saving bug * Apply selection view * Improve visuals for elements selection - Better colors; - Show move cursor only when hovering elements that actually allow move the group - Show big box around all selected elements - Show individual dashed border around each selected element (Avoid missguide users in some cases were elements not selected are inside the big box; * Clear selection on add new elements to the graph or select a single one * Fix ISA shape on load to graph from json * Starting side bar control * Adding lib angular-translate (#152) * Adding angular-translate * Adding flag svgs and style * Config angular-translate and add some words * Removing nested class * Add single quote * Updating svg flags * Removing unnecessary script * Add single quote * Start removing migreted code from controller * Fix image load on login * Start logic component migration * Format file * Create logic editor component * Inject services * Remove unsed files * Broadcast events to screnn update * Fix jointjs version to 3.3.0 * Apply update on remove links * Apply duplicate model * Migrate columns dropdowns * Update app name to "BR Modelo Web" (#164) * Migrate sql conversor * Remove dead code * Migrate conversion service * Menu icon migration * Webpack optimization and frontend-backend running on the same port * Fix webpack.config * Migrate logout * Adds ocLazyLoad in the routes to configure bundle chucks * Fixes wrong import on logic route * Adds the splitChunks optimization configuration * Fix duplicateModelModal html import * Deploy webpack attempt * Deploy webpack attempt 2 * Deploy webpack attempt 3 * Deploy webpack attempt 3 * Deploy webpack attempt 4 * Deploy webpack attempt 5 * Deploy webpack another attempt * Feature/password recovery (#165) (#170) * Login page recovery option - Add link to recovery password at login screen - .separator styles - .btn-alt styles * Reset password markup - Step 1 - Recovery: Enter email - Step 2 - Email (Not present in this commit) - Step 3 - Reset: Redefine password * Create base recovery endpoint * Create to link to recovery module * Create recovery component * Wireup recovery component * Finish recovery component * Create reset endpoint * Create reset component * Wireup reset component * Reduce top white space for public pages We notice some users using narrow screens (Or screens with lower resolution) are having issues of content being hidden under vertical scrool. To mitigate this problem, I'm reducing the gap between viewport top and content to all public pages. * Bubfix: Adjust .br-loader position * Create mailService * Create email template * Remove unused files Co-authored-by: miltonbst@gmail.com <miltonbst@gmail.com> Co-authored-by: miltonbst@gmail.com <miltonbst@gmail.com> * Removes @uirouter/visualizer dependency * Creating file base url * Removing duplicated script * Update readme and yarn scripts * Removing gulp from project * Adds prettier config file to avoid endOfLine errors * Configure dotenv in the server application * Disables no-underscore-dangle eslint rule * Configures dotenv in the client site * Creates a https interceptor to add a baseUrl and refac services with http requests * Adds env files to the gitignore * Hide footer with flags * Updates Readme - Added a step about the env configuration in the Running application section * Replaces unecessary template string with double quotes * Add regex to filter template html * Update README.md - Better instructions to project setup - Better copy to .env.eample steps * Update README.md - Fix command to start development environment: yarn start:dev * Add form-data to dependecies * Add systemvars true to use on Heroku * Fix start server script on Readme * Hotfix/convertion (#192) * Fix link connection * Remove log * Add attribute on relation validation (#195) * Bugfix #183: Report bug :hover state Fix the "dancing" behavior caused during :hover state depending of mouse position. * Bugfix #183: Report bug visible on print view Use bootsrapt auxiliar class to hide element in print view * Remove sweet-feedback #179: Change HTML markup Remove remaining places using sweet-feedback markup Overwrite it with feedback module from Bootstrap - Conceptual view - Logic view * Remove sweet-feedback #179: CSS adjustments Small interface adjustments to improve how we display feedback modules inside of .workspace-header * Remove sweet-feedback #179: Remove dependencies - Remove sweet-feedback from package.json - Remove CSS link from page <head> - Remove import modile from angular/index.js - Remove from yarn.lock * Update "back" buttom on publick pages The back buttom clickable area was overflowing the text due to flexbox definition. In order to fix this we're adding a <div> around the <a> element. * Conceptual empty state * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Fixes button alignment on sign up form On the sign up screen there is a back button, which is aligned to the left, and on the password recovery screen the button is centered. This commit will standardize the alignment of the buttons on these screens. * Update README.md - Add link to `<h1>` - Add app preview image - Fix headers hierarchy * Fix error on connect to blank point on screen (#199) Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> * Update env example * Conceptual name edition * Add entity edition properties * Add validation to Entity-Extension * Add auto-relationship functionality * Add .nvmrc to define NodeJS version * Migrate extension conversion modal * Code format * Migrate conversion n to n (#214) * Migrate cardinality edition * Migrate conversion n1 (#217) * Migrate conversion 11 * Update sintaxe (#219) * Update sintaxe * Fixing jest test * Migrate extension children only option (#220) * Migrate Attribute cardinality edition (#222) * Migrate conversion n to n (#224) * Migrate associative (#225) * Relationship to associative (#235) * Relationship to associative * Migration attribute composed (#237) * Migrate attribute composed * Add image to canvas * Replace image to composed on drop * Quick and dirty fix to "Composto" preview Small tweaks in the .png image used to represent "Composto" in #stencil-holder Co-authored-by: Idmar Ramos Jr. (Id) <idmarjr@gmail.com> * Migration clean up (#236) * Logic sidebar empty state * Delete unused files Co-authored-by: Idmar Ramos Junior (Id) <idmarjr@gmail.com> Co-authored-by: Márcio Santos <marcio.tbms@gmail.com> Co-authored-by: Arthur Mota <arthurmotaa9@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> Co-authored-by: Milton <miltonbst@gmaill.com>
miltonbsn
added a commit
that referenced
this pull request
Nov 29, 2021
* Feature/password recovery (#165) * Login page recovery option - Add link to recovery password at login screen - .separator styles - .btn-alt styles * Reset password markup - Step 1 - Recovery: Enter email - Step 2 - Email (Not present in this commit) - Step 3 - Reset: Redefine password * Create base recovery endpoint * Create to link to recovery module * Create recovery component * Wireup recovery component * Finish recovery component * Create reset endpoint * Create reset component * Wireup reset component * Reduce top white space for public pages We notice some users using narrow screens (Or screens with lower resolution) are having issues of content being hidden under vertical scrool. To mitigate this problem, I'm reducing the gap between viewport top and content to all public pages. * Bubfix: Adjust .br-loader position * Create mailService * Create email template * Remove unused files Co-authored-by: miltonbst@gmail.com <miltonbst@gmail.com> * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Fixes button alignment on sign up form On the sign up screen there is a back button, which is aligned to the left, and on the password recovery screen the button is centered. This commit will standardize the alignment of the buttons on these screens. * Update README.md - Add link to `<h1>` - Add app preview image - Fix headers hierarchy * Fix error on connect to blank point on screen (#199) Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> * docs: add joaomfiumari as a contributor for code, infra (#203) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Add dockerfile and dockercompose configuration (#202) Co-authored-by: Joao Paulo Maiamaral Fiumari <joao.paulo@yalochat.com> * feature: export model endpoint (#213) * Adds export model endpoint This commit adds the necessary structure to export model Resolves #75 * Adds import model endpoint This commit adds import model endpoint for tests Resolves #76 * Adds crypto unit test Refs #75 #76 * Adds export model unit test Resolves #75 * Feature/webpack migration (#153) * Start webpack migration * Release version (#142) * Add new SVG logos (Round and Square) - Based in the original logo - SVG so we have more flexibility increasing size if needed * New public pages style (Login, Sign up) - Use Boorstrap markup to forms; - Add waves graph to add soome life to public pages; - Use Square SVG logo - Add more weight to <h1> font * Fix form name and css error class * Show waves background only in public pages * Adjust accessiblity outline to match product color [ ! ] Keep in mind this is an acessibility feature and we need to be careful when removing/changing this kind of behaviour - Remove outline from button, input type button and type submit; - Use box shadow to emulate ottline behaviour instead; - Add transition to box shadow * Add transition to .form-control:focus Co-authored-by: Idmar Ramos Junior (Id) <idmarjr@gmail.com> * Release version (#148) * Add new SVG logos (Round and Square) - Based in the original logo - SVG so we have more flexibility increasing size if needed * New public pages style (Login, Sign up) - Use Boorstrap markup to forms; - Add waves graph to add soome life to public pages; - Use Square SVG logo - Add more weight to <h1> font * Fix form name and css error class * Show waves background only in public pages * Adjust accessiblity outline to match product color [ ! ] Keep in mind this is an acessibility feature and we need to be careful when removing/changing this kind of behaviour - Remove outline from button, input type button and type submit; - Use box shadow to emulate ottline behaviour instead; - Add transition to box shadow * Add transition to .form-control:focus * Add Google Analytics tracking code * Fix indentation Co-authored-by: Milton Bittencourt <miltonbst@gmail.com> * Creates the initial webpack config * Exporting angularjs components as module and a modal example * Add dist to .gitignore * login component cleanup * Inject dependency properly * Create new dropdown component * Adapt modals to work with components and webpack * Create workspace module component * Add module cors to work with separed servers * Adapt modelAPI to webpack * Delete unused files * Replace dropdown directive for new component * Wrapup new workspace module component * Changes the style files imports in order to fix wrong font style * Configures react2angular and migrates the Login button to a React component * Allows jsx extensions * Fix fontawsome import * Configures the HtmlWebpackPlugin * Create <div class=modal-header> * Create createModelModal component * Create deleteModelModal component * Create renameModelModal component * Inject new modal components * Import and inject new components * Reorganize imports in order to improve performance * Clean unused files * Update README.md - Add yarn to dependencies section - Change npm to yarn commands - Change localhost port to 3000 to 9000 * Fix workspace header * Starting conceptual componetization * Fix drag and drop issues * Finish drag and drog deature * Link commands * Conceptual - load saved model * Conceptual - save model * Conceptual - duplicate model * Conceptual - conversion call * Conceptual - apply halo * Configure jest to run with angular * Create erd factory module * Create erd validator module * Create erd linker module * Refactoring to use modules * Testing erd factory module * Update .gitignore * Increase coverge linker.js * Fix saving bug * Apply selection view * Improve visuals for elements selection - Better colors; - Show move cursor only when hovering elements that actually allow move the group - Show big box around all selected elements - Show individual dashed border around each selected element (Avoid missguide users in some cases were elements not selected are inside the big box; * Clear selection on add new elements to the graph or select a single one * Fix ISA shape on load to graph from json * Starting side bar control * Adding lib angular-translate (#152) * Adding angular-translate * Adding flag svgs and style * Config angular-translate and add some words * Removing nested class * Add single quote * Updating svg flags * Removing unnecessary script * Add single quote * Start removing migreted code from controller * Fix image load on login * Start logic component migration * Format file * Create logic editor component * Inject services * Remove unsed files * Broadcast events to screnn update * Fix jointjs version to 3.3.0 * Apply update on remove links * Apply duplicate model * Migrate columns dropdowns * Update app name to "BR Modelo Web" (#164) * Migrate sql conversor * Remove dead code * Migrate conversion service * Menu icon migration * Webpack optimization and frontend-backend running on the same port * Fix webpack.config * Migrate logout * Adds ocLazyLoad in the routes to configure bundle chucks * Fixes wrong import on logic route * Adds the splitChunks optimization configuration * Fix duplicateModelModal html import * Deploy webpack attempt * Deploy webpack attempt 2 * Deploy webpack attempt 3 * Deploy webpack attempt 3 * Deploy webpack attempt 4 * Deploy webpack attempt 5 * Deploy webpack another attempt * Feature/password recovery (#165) (#170) * Login page recovery option - Add link to recovery password at login screen - .separator styles - .btn-alt styles * Reset password markup - Step 1 - Recovery: Enter email - Step 2 - Email (Not present in this commit) - Step 3 - Reset: Redefine password * Create base recovery endpoint * Create to link to recovery module * Create recovery component * Wireup recovery component * Finish recovery component * Create reset endpoint * Create reset component * Wireup reset component * Reduce top white space for public pages We notice some users using narrow screens (Or screens with lower resolution) are having issues of content being hidden under vertical scrool. To mitigate this problem, I'm reducing the gap between viewport top and content to all public pages. * Bubfix: Adjust .br-loader position * Create mailService * Create email template * Remove unused files Co-authored-by: miltonbst@gmail.com <miltonbst@gmail.com> Co-authored-by: miltonbst@gmail.com <miltonbst@gmail.com> * Removes @uirouter/visualizer dependency * Creating file base url * Removing duplicated script * Update readme and yarn scripts * Removing gulp from project * Adds prettier config file to avoid endOfLine errors * Configure dotenv in the server application * Disables no-underscore-dangle eslint rule * Configures dotenv in the client site * Creates a https interceptor to add a baseUrl and refac services with http requests * Adds env files to the gitignore * Hide footer with flags * Updates Readme - Added a step about the env configuration in the Running application section * Replaces unecessary template string with double quotes * Add regex to filter template html * Update README.md - Better instructions to project setup - Better copy to .env.eample steps * Update README.md - Fix command to start development environment: yarn start:dev * Add form-data to dependecies * Add systemvars true to use on Heroku * Fix start server script on Readme * Hotfix/convertion (#192) * Fix link connection * Remove log * Add attribute on relation validation (#195) * Bugfix #183: Report bug :hover state Fix the "dancing" behavior caused during :hover state depending of mouse position. * Bugfix #183: Report bug visible on print view Use bootsrapt auxiliar class to hide element in print view * Remove sweet-feedback #179: Change HTML markup Remove remaining places using sweet-feedback markup Overwrite it with feedback module from Bootstrap - Conceptual view - Logic view * Remove sweet-feedback #179: CSS adjustments Small interface adjustments to improve how we display feedback modules inside of .workspace-header * Remove sweet-feedback #179: Remove dependencies - Remove sweet-feedback from package.json - Remove CSS link from page <head> - Remove import modile from angular/index.js - Remove from yarn.lock * Update "back" buttom on publick pages The back buttom clickable area was overflowing the text due to flexbox definition. In order to fix this we're adding a <div> around the <a> element. * Conceptual empty state * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Fixes button alignment on sign up form On the sign up screen there is a back button, which is aligned to the left, and on the password recovery screen the button is centered. This commit will standardize the alignment of the buttons on these screens. * Update README.md - Add link to `<h1>` - Add app preview image - Fix headers hierarchy * Fix error on connect to blank point on screen (#199) Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> * Update env example * Conceptual name edition * Add entity edition properties * Add validation to Entity-Extension * Add auto-relationship functionality * Add .nvmrc to define NodeJS version * Migrate extension conversion modal * Code format * Migrate conversion n to n (#214) * Migrate cardinality edition * Migrate conversion n1 (#217) * Migrate conversion 11 * Update sintaxe (#219) * Update sintaxe * Fixing jest test * Migrate extension children only option (#220) * Migrate Attribute cardinality edition (#222) * Migrate conversion n to n (#224) * Migrate associative (#225) * Relationship to associative (#235) * Relationship to associative * Migration attribute composed (#237) * Migrate attribute composed * Add image to canvas * Replace image to composed on drop * Quick and dirty fix to "Composto" preview Small tweaks in the .png image used to represent "Composto" in #stencil-holder Co-authored-by: Idmar Ramos Jr. (Id) <idmarjr@gmail.com> * Migration clean up (#236) * Logic sidebar empty state * Delete unused files Co-authored-by: Idmar Ramos Junior (Id) <idmarjr@gmail.com> Co-authored-by: Márcio Santos <marcio.tbms@gmail.com> Co-authored-by: Arthur Mota <arthurmotaa9@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> Co-authored-by: Milton <miltonbst@gmaill.com> * Update yarn.lock (#242) * Bump jointjs from 3.3.0 to 3.4.2 (#239) * Bump jointjs from 3.3.0 to 3.4.2 Bumps [jointjs](https://github.com/clientIO/joint) from 3.3.0 to 3.4.2. - [Release notes](https://github.com/clientIO/joint/releases) - [Changelog](https://github.com/clientIO/joint/blob/master/CHANGELOG) - [Commits](clientIO/joint@v3.3.0...v3.4.2) --- updated-dependencies: - dependency-name: jointjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Import fixes to joint update Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Milton Bittencourt <miltonbst@gmail.com> * Fix modal opening (#244) * Update yarn.lock * Fix ConversionOptionModal opening * Fix JointJS sideEffect issue (#245) * fix: workaround to fix jointjs sideEffect issue * refactor: changes code comment * Copy images to dist folder when run yarn build (#246) * Add first end-to-end test (#243) * Add first end-to-end test * Add missing info on readme * Update README.md Tweak wording. Co-authored-by: Idmar Ramos Jr. (Id) <idmarjr@gmail.com> * docs: add wlsf82 as a contributor for test (#247) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Register shortcuts * Create keyboardController * Add keyboard shortcut hint to .tool-icons items Since we're not checking user OS in any ways, for now I'm using CTRL as key identifier and assume Mac users will know they need to use CMD instead. * Add keyboard shortcut hint to save button * Simplify login custom command So that it can be used not only for testing the happy login flow, but also unhappy paths. * Increate login flow test coverage * Standardizes editors behavior * fix: jointjs style in the logic model (#250) * Remove missing debug log * Add types and create hotkeys config (#253) Authored-by: Arthur Mota <arthurmotaa9@gmail.com> * Refactor login tests and custom command The login tests now have better assertions. And the login custom command can now use the cy.session experimental feature, which allows restoring the session of a user, which speeds up tests. But, for the login tests, we don't want any cache to be restored. This is why for the login tests we pass { cacheSession: false } * Add tests for models Such tests make use of the refactored login command, which means that only the first tests needs to log in via the GUI, while others benefit from the session to be restored from the cache. In this test suite, I've also create a custom command to cleanup all existing models on the beforeEach hook so that tests always start in a fresh state. * Add date fields to model database (#252) * Minor adjustments * Overwrite cypress request timeout * Fix variable name * Zoom keyboard shortcut fixes - Simplify zoom sortcuts * WIP: Add 100% zoom option * Draft new link management * Increase test coverage of model creation This is a POC for testing drag-and-drop actions. * Fix frozen inputs on editors (#261) * 167 - Prevent exit without saving (#257) * Create new toolsview * Clean code * Code format * Remove unused code * Apply zoomNone * Remove unused files * Remove unsued files * Upgrade node to v16 (#262) * feat: upgrade node 14 * refactor: upgrade to v16 * refactor: updates yarn.lock * feat: specify yarn version in package.json, also removes npm Co-authored-by: Milton Bittencourt <miltonbst@gmail.com> Co-authored-by: Idmar Ramos Jr. (Id) <idmarjr@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arthur Mota <arthurmotaa9@gmail.com> Co-authored-by: Arthur Mota <arthur.nascimento@mercadolivre.com> Co-authored-by: Milton de Souza Neto <miltondesouzaneto@MacBook-Pro-de-Milton.local> Co-authored-by: joaomfiumari <joaopaulo_mf@outlook.com> Co-authored-by: Joao Paulo Maiamaral Fiumari <joao.paulo@yalochat.com> Co-authored-by: Felipe de Souza da Costa <felipe.dacosta@mercadolivre.com> Co-authored-by: Márcio Santos <marcio.tbms@gmail.com> Co-authored-by: Milton <miltonbst@gmaill.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Walmyr <wlsf82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.