Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gatk to snapshot of jp_fix_file_walker branch in google-cloud-java, and craft test case to prove the fix works #3118

Closed
droazen opened this issue Jun 15, 2017 · 1 comment · Fixed by #3295
Closed

Move gatk to snapshot of jp_fix_file_walker branch in google-cloud-java, and craft test case to prove the fix works #3118

droazen opened this issue Jun 15, 2017 · 1 comment · Fixed by #3295
Assignees
@lbergelson
Labels
NIO
Milestone
Engine-beta2

Comments

@droazen
Copy link
Collaborator

droazen commented Jun 15, 2017

This will provide a temporary fix for #2793 so that we can release beta
@droazen droazen self-assigned this Jun 15, 2017
@droazen droazen added the NIO label Jun 15, 2017
@droazen droazen added this to the Engine-beta milestone Jun 15, 2017
@droazen droazen modified the milestones: Engine-4.0, Engine-beta1 Jun 23, 2017
@droazen droazen modified the milestones: Engine-beta2, Engine-4.0 Jul 10, 2017
@droazen droazen mentioned this issue Jul 17, 2017
Merged
droazen added a commit that referenced this issue Jul 17, 2017
@droazen
Move to google-cloud-java snapshot with more robust retries, and set …
96f627b 
…number of retries/reopens globally

This moves us to a snapshot of google-cloud-java based off of a branch in my fork here:
https://github.com/droazen/google-cloud-java/tree/dr_retry_CloudStorageReadChannel_fetchSize.
This patch wraps many more operations within retries, and in our tests
resolves the intermittent 503/SSL errors completely when running at scale.

This PR also migrates us from setting retry settings per-Path to setting it globally,
using a new API from that google-cloud-java branch. This fixes an issue where the
number of reopens was getting set to 0 deep in the google-cloud-java library.

Resolves #2749
Resolves #2685
Resolves #3118
Resolves #3120
Resolves #3253
droazen added a commit that referenced this issue Jul 20, 2017
@droazen
Move to google-cloud-java snapshot with more robust retries, and set …
4c697e0 
…number of retries/reopens globally (#3295)

Move to google-cloud-java snapshot with more robust retries, and set number of retries/reopens globally

This moves us to a snapshot of google-cloud-java based off of a branch in my fork here:

https://github.com/droazen/google-cloud-java/tree/dr_better_nio_retries

This patch wraps many more operations within retries, and in our tests
resolves the intermittent 503/SSL errors completely when running at scale.

This PR also migrates us from setting retry settings per-Path to setting it globally,
using a new API from that google-cloud-java branch. This fixes an issue where the
number of reopens was getting set to 0 deep in the google-cloud-java library.

Resolves #2749
Resolves #2685
Resolves #3118
Resolves #3120
Resolves #3253
@droazen
Copy link
Collaborator Author

droazen commented Jul 20, 2017

Re-opening this one, since the "craft test case" part of this ticket has not yet been done -- we've just moved to an updated snapshot.

@droazen droazen reopened this Jul 20, 2017
@droazen droazen assigned lbergelson and unassigned droazen Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbergelson lbergelson

Labels
NIO
Projects
None yet
Milestone
Engine-beta2
2 participants
@droazen @lbergelson